aws-samples / dbt-glue

This repository contains de dbt-glue adapter
Apache License 2.0
91 stars 59 forks source link

Re-submit #301 to enable users to fix their glue_session_id name and re-use it #321

Closed moomindani closed 5 months ago

moomindani commented 5 months ago

In # 319, We needed to revert multiple PRs including https://github.com/aws-samples/dbt-glue/pull/286. This PR is to re-submit PR #301 to enable users to fix their glue_session_id name and re-use it.

Description

To re-use a glue session, we currently have to 1/ dbt run with glue_session_reuse: true and #glue_session_id commented 2/ copy paste the resulting glue session in glue_session_id and uncomment it.

If the session is stopped (you waited too long), step 2 will failed to re-use, you have to repeat the whole process.

Solution

We add the following logic, when a glue_session_id is provided by the user:

When a glue_session_id is not provided, the behavior of generating a unique glue_session_id is kept.

Checklist

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.