aws-samples / dbt-glue

This repository contains the dbt-glue adapter
Apache License 2.0
96 stars 67 forks source link

[Bug]: `pre-commit` Hooks Fail #344

Open danphenderson opened 7 months ago

danphenderson commented 7 months ago

Describe the bug

This is more of a code smell than a bug, and it makes the development process a headache for future contributors.

Checkout main and execute: pre-commit run --all-files. It will update these files:

        modified:   .github/PULL_REQUEST_TEMPLATE.md
        modified:   README.md
        modified:   dbt/adapters/glue/__version__.py
        modified:   dbt/adapters/glue/column.py
        modified:   dbt/adapters/glue/connections.py
        modified:   dbt/adapters/glue/credentials.py
        modified:   dbt/adapters/glue/gluedbapi/__init__.py
        modified:   dbt/adapters/glue/gluedbapi/commons.py
        modified:   dbt/adapters/glue/gluedbapi/connection.py
        modified:   dbt/adapters/glue/gluedbapi/cursor.py
        modified:   dbt/adapters/glue/impl.py
        modified:   dbt/adapters/glue/lakeformation.py
        modified:   dbt/adapters/glue/relation.py
        modified:   dbt/adapters/glue/util.py
        modified:   dbt/include/glue/__init__.py
        modified:   dbt/include/glue/macros/materializations/incremental/incremental.sql
        modified:   dbt/include/glue/macros/materializations/snapshot.sql
        modified:   dbt/include/glue/macros/materializations/table/iceberg_table_replace.sql
        modified:   dbt/include/glue/macros/materializations/table/table.sql
        modified:   dbt/include/glue/macros/materializations/view.sql
        modified:   dbt/include/glue/sample_profiles.yml
        modified:   dev-requirements.txt
        modified:   etc/dbt-logo-full.svg
        modified:   etc/dbt-logo.svg
        modified:   setup.py
        modified:   tests/conftest.py
        modified:   tests/functional/adapter/test_basic.py
        modified:   tests/functional/adapter/test_docs.py
        modified:   tests/functional/adapter/test_snapshot.py
        modified:   tests/functional/conftest.py
        modified:   tests/functional_test/adapter/test_glue_session.py
        modified:   tests/functional_test/conftest.py
        modified:   tests/pytest.ini
        modified:   tests/unit/pytest.ini
        modified:   tests/unit/test_adapter.py
        modified:   tests/unit/test_credentials.py
        modified:   tests/unit/test_lakeformation.py
        modified:   tests/unit/test_relation.py
        modified:   tests/unit/util.py
        modified:   tests/util.py

And it will display a bunch of errors that need to be fixed.