Closed aiss93 closed 3 weeks ago
@aiss93 Apologizes I forgot to submit my comments last week. Submitted them now. Having test_iceberg is good idea, but I think we still need to make sure that we have enough coverage in the test cases. Plz refer to my comments.
Hi @moomindani do you have any additional comments or can we launch the functional tests ? Thank you for your time
Hi @moomindani do you have any additional comments or can we launch the functional tests ? Thank you for your time
Thanks for making changes based on my comments. Apologizes for delay in review. We are still reviewing the changes. It may take some time as our bandwidth is very limited this month, but let us update you.
Sure thank you !
Thank you for your contribution! This patch brought huge value, we really appreciate your contribution.
resolves #457
Description
The following PR addresses the following points:
Checklist
CHANGELOG.md
and added information about my change to the "dbt-glue next" section.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.