aws-samples / eb-docker-nginx-proxy

Apache License 2.0
145 stars 81 forks source link

weird naming #5

Open InternetPseudonym opened 7 years ago

InternetPseudonym commented 7 years ago

This will not configure a nginx proxy, in fact it will configure a (more or less) standard nginx instance which uses php-fpm via TCP (which is several orders of magnitude slower than unix sockets, btw) on a seperate container.

I think you should fix your nomenclature - its really confusing and will mislead beginners. Also : you should consider changing the example to unix sockets ... using TCP is a really, really bad idea unless you are absolutely forced to do so (like in a restricted intranet without filesystem access to your FPM daemon) - use the full power of AWS ... EC2 instances can be pretty limited if you dont want to invest hundreds of dollars, performance is a key factor