search

aws-samples / eb-php-wordpress

Configuration files and instructions for installing WordPress securely and running it in a load balanced AWS Elastic Beanstalk environment with an EFS file system for shared assets.
Apache License 2.0
165 stars 95 forks source link

Added missing vars to wordpress.config #12

Closed jribe closed 6 years ago

jribe commented 7 years ago

These variables are used in wp-config.php, but aren't included in this convenience list.

mwunderl commented 6 years ago

We should add LOGGED_IN_SALT, but what's the point of adding the database variables?

jribe commented 6 years ago

Convenience. Having all the variables added by default makes it easier to go through the setup process.

mwunderl commented 6 years ago

Can you tell me how? For both sets of instructions, the environment variables should be configured before you install WP. Thanks, -Michael

jribe commented 6 years ago

The instructions I used (http://docs.aws.amazon.com/elasticbeanstalk/latest/dg/php-hawordpress-tutorial.html) tell you to create the EB environment first, then configure the environment variables.

When using that workflow, these default values are already populated in the EB management UI when you go to configure the environment variables. In the current state, a subset of variables are populated this way, so the user needs to double-check and cross-reference the documentation in order to make sure that they've added all of the variables.

mwunderl commented 6 years ago

Makes perfect sense. Thank you!