search

aws-samples / ec2-classic-resource-finder

This script enables the identification of resources running in Amazon EC2 Classic
MIT No Attribution
131 stars 82 forks source link

a continue statement will make this run faster for regions without classic #21

Closed jthomasser closed 2 years ago

jthomasser commented 2 years ago

thanks for this script. good stuff. just wanted to add that by adding a continue statement after line 59 will avoid running unnecessary code so will go alot faster by restarting at the for loop.

as follows:

59 else printf "$region, Disabled\n" >> Classic_Platform_Status.csv ## If supported platforms is only VPC and does not include EC2, output the region and Disabled to a CSV 60 printf "$region, Classic disabled, skipping checks.\n" 61 continue

TheScottMo commented 2 years ago

I have released version 2 today, which runs with a high degree of parallelization and I am seeing a lot of improvement in speed now. Thank you for the feedback.