aws-samples / ecs-blue-green-deployment

Reference architecture for doing blue green deployments on ECS.
Apache License 2.0
462 stars 474 forks source link

Do not require public-read acl #13

Open jwoehrle opened 4 years ago

jwoehrle commented 4 years ago

Issue: some companies do not allow the usage of public-read ACL for S3. In that case the bin/deploy aws s3 cp <filename> <target-bucket> --acl public-read will fail.

Description of changes: This change removes the --acl public-read. To make sure cloudformation is still able to access the file in the s3 bucket its execution role gets s3:GetObject permission on the template bucket.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.