search

aws-samples / ecs-cid-sample

In this code provided with the blog, we will demonstrate how to use the draining state to update the AMI used by EC2 instances in your cluster by updating the launch configuration of your auto-scaling group. The process also ensures that the EC2 instances get the tasks drained the tasks launch on new container instance before termination occurs.
Apache License 2.0
103 stars 76 forks source link

Change to list only SNS subscriptions by subscribed topic #5

Open jveldboom opened 7 years ago

jveldboom commented 7 years ago

Update to loop over just the subscribed SNS topic in the event.

Also by default list_subscriptions() returns 100 subscriptions at a time. So if you have more than 100, it might not find the correct subscription.

r3m0t commented 7 years ago

Why do you need the subscription at all? You're just reading the TopicArn that you passed in

ardelio commented 6 years ago

Agree. No need to check subscriptions. Just publish straight away.

ardelio commented 6 years ago

This should be closed in favour of PR #14