search

aws-samples / eks-anywhere-addons

https://aws-samples.github.io/eks-anywhere-addons/
MIT No Attribution
21 stars 39 forks source link

Sample Tester manifest is Job, should be CronJob #142

Closed jkodroff closed 7 months ago

jkodroff commented 9 months ago

The Sample test job https://github.com/aws-samples/eks-anywhere-addons/blob/main/eks-anywhere-common/Testers/Sample/testJob.yaml is a Job and should be a CronJob.

jkodroff commented 9 months ago

It looks like it's wrong in multiple files (eks-anywhere-*/Testers/Sample/testJob.yaml)

elamaran11 commented 7 months ago

Thanyou @jkodroff for this issue, we will work on this.

elamaran11 commented 7 months ago

@mikemcd3912 Please add this to your backlog. Our sample job needs to be updated for CronJob

jkodroff commented 7 months ago

@elamaran11 Is there a trick I might not know about to keep the resource as a CronJob but still making it easy to test like a Job is? e.g. Is there a way to keep the common "work" separate from the scheduling part?

elamaran11 commented 7 months ago

@jkodroff Not sure i understand your question because once you change to CronJob it runs a Job on schedule which is what we want to do with this.