Moving Solo.io Istio to revisions

aws-samples / eks-anywhere-addons

https://aws-samples.github.io/eks-anywhere-addons/

MIT No Attribution

20 stars 40 forks source link

Moving Solo.io Istio to revisions #255

Closed PetrMc closed 5 months ago

PetrMc commented 5 months ago

Issue #,https://github.com/aws-samples/eks-anywhere-addons/issues/252

Description of changes:

This PR:

Transfers the Solo Istio Distro to the solo-istio-system namespace.
Introduces revision support to enable multiple Istio Control Planes to coexist within the same cluster.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

elamaran11 commented 5 months ago

Thankyou @PetrMc for a rapid quick PR. We will get this validated soon.

mikemcd3912 commented 5 months ago

Hi @PetrMc , Apologies for the change here but we needed to revert the PR based on a conflict that we suspect it was causing with the other Istio add-on that we are attempting to run/test alongside Solo. We believe that the use of discoverySelector to isolate solo would remedy the issue. If you could please resubmit the PR with discoverySelector implemented to focus on just the Solo solution that would be appreciated. Thanks, and let me know if you have any questions!

PetrMc commented 5 months ago

@mikemcd3912 / @elamaran11 - please review https://github.com/aws-samples/eks-anywhere-addons/pull/261/