search

aws-samples / eks-anywhere-addons

https://aws-samples.github.io/eks-anywhere-addons/
MIT No Attribution
20 stars 40 forks source link

Feature/external snapshotter bare metal and vSphere #43

Closed elamaran11 closed 1 year ago

elamaran11 commented 1 year ago

Issue #, if available:

Description of changes:

Storage Drivers with OpenEBs and CSI Snapshotters for BareMetal along with testing process. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

elamaran11 commented 1 year ago

@elamaran11 how many storage classes do we define for baremetal? If jiva is the only class, should not it be marked as default? (currently is set to false)

@shapirov103 This deployment deploys 4 storage classes. Customers can choose between hostpath or Jiva upon their choice as default. I kept it default to false so customers can choose the one they wish. We dont want to force an sc.

shapirov103 commented 1 year ago

@shapirov103 This deployment deploys 4 storage classes. Customers can choose between hostpath or Jiva upon their choice as default. I kept it default to false so customers can choose the one they wish. We dont want to force an sc.

@elamaran11 This support for storage classes is not a generic approach for EKS-A, but rather is a part of the conformance framework which should work out-of-the-box for partner integrations. We don't want partners to specify a particular storage class when provisioning volumes. If partner add-on creates a volume without specifying the storage class, what will happen?

elamaran11 commented 1 year ago

@shapirov103 For vSphere and BareMetal OpenEBS cstor CSI will be our default storage class for our conformance framework. Customers dont have a need to specify a default storage class in their snippet, it will use CSTOR CSI by default. I have given it as a way to give in example. I have also fixed your Job comment. All good now.