Closed manuelbcd closed 1 year ago
@manuelbcd We need a test job as we discussed to validate and pass this PR.
Test job submitted.
Hi @manuelbcd As per our slack conversation. We need an explicit job like how we have in samples though the product has an agent. The sysdig agent is part of the product. What we need a job which is outside the product and does some functional test on the product. We cant accept anything now without the test job which is explicit to test on other deployment models like Nutanix.
If you think only readiness check is needed, Please provide that as a test or separate job to close the thread.
I'm sorry I did not commit all the files. Please review again @elamaran11
@manuelbcd The job fails with below error. The namespace specified should be sysdig
for the test job.
flux-system testers 12d False Job/sysdig-agent/sysdig-agent-tester namespace not specified, error: namespaces "sysdig-agent" not found...
namespace switched to "sysdig" to match with the original name, thanks @elamaran11
@manuelbcd Job has an error with syntax. Appreciate if you can test it before pushing changes for test: Also this doesnt look like a functional test. You are looking for running pods.
error: error executing jsonpath "{.items[0].metadata.name}": Error executing template: array index out of bounds: index 0, length 0. Printing more information for debugging the template:
template was:
{.items[0].metadata.name}
object given to jsonpath engine was:
map[string]interface {}{"apiVersion":"v1", "items":[]interface {}{}, "kind":"List", "metadata":map[string]interface {}{"resourceVersion":""}}
Please check again @elamaran11
@manuelbcd The job runs for ever and see the logs below :
nutanix@devstation:~$ k logs sysdig-agent-tester-b9wln -n sysdig
1. Checking readiness probe sysdig_pod=...
Waiting
2. Checking audit port sysdig_audit=...
@manuelbcd I can now see the test job working fine with your new changes :
nutanix@devstation:~$ k logs sysdig-agent-tester-hws8j -n sysdig
1. Checking readiness probe sysdig_pod=...
Waiting
2. Checking audit port sysdig_audit=...
Connecting
Success
@manuelbcd As discussed over slack. I hve validated the latest change you had an hour ago in all deployments models and everything works fine now. I can see the test job executing fine. Only change is you need to remove sysdig
from Snow addons folder here https://github.com/aws-samples/eks-anywhere-addons/tree/main/eks-anywhere-snow/Addons/Partner/Sysdig because we have it in core, it syncs to all deployment models of EKS. Please do it asap to pass.
@shapirov103 I have validated the test job in all deployment models so please review and approve.
Description of changes:
Added Sysdig addon to the EKS-A-Common partners folder