search

aws-samples / eks-blueprints-add-ons

MIT No Attribution
139 stars 763 forks source link

feat: Adding Grafana Helm Chart #85

Closed sharepointoscar closed 2 years ago

sharepointoscar commented 2 years ago

Closes #84

Description of changes: When enabling the Grafana add-on in terraform, the chart never got deployed, only related IAM resources listed below. This PR adds the Grafana Chart and add-on definitions.

➜ terraform state list | grep grafana
module.kubernetes-addons.module.grafana[0].data.aws_iam_policy_document.this
module.kubernetes-addons.module.grafana[0].aws_iam_policy.grafana
module.kubernetes-addons.module.grafana[0].module.helm_addon.module.irsa[0].aws_iam_role.irsa[0]
module.kubernetes-addons.module.grafana[0].module.helm_addon.module.irsa[0].aws_iam_role_policy_attachment.irsa[0]
module.kubernetes-addons.module.grafana[0].module.helm_addon.module.irsa[0].kubernetes_namespace_v1.irsa[0]
module.kubernetes-addons.module.grafana[0].module.helm_addon.module.irsa[0].kubernetes_service_account_v1.irsa[0]

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Zvikan commented 2 years ago

Looking back at how other addons are added here, in the main chart values we should add the default grafana values: https://github.com/aws-samples/eks-blueprints-add-ons/blob/main/chart/values.yaml which is currently missing in this PR, can you please add it @sharepointoscar.

sharepointoscar commented 2 years ago

https://github.com/aws-samples/eks-blueprints-add-ons/blob/main/chart/values.yaml

Thank you @Zvikan , I will add grafana default values as per your comment!

sharepointoscar commented 2 years ago

https://github.com/aws-samples/eks-blueprints-add-ons/blob/main/chart/values.yaml

Thank you @Zvikan , I will add grafana default values as per your comment!

The Grafana add-on is now fully tested. All resources are deployed successfully, and one can add additional values to override defaults. 🚀 image