Clarify and facilitate tf remote state creation

aws-samples / eks-blueprints-for-proton

MIT No Attribution

28 stars 30 forks source link

Clarify and facilitate tf remote state creation #22

Closed jritsema closed 2 years ago

jritsema commented 2 years ago

adds context to change into directory with GithubConfiguration.yaml file (I missed that the first time)
adds a tf-state.sh script that users can run

It seems odd that in a post talking about Terraform, we're asking users to use Cloudformation to deploy something :) I know of several Terraform shops that have almost no knowledge or experience with CFN so this might feel very strange. I'd be happy to port this over to Terraform and provide instructions if you're interested. Just let me know.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

mreferre commented 2 years ago

Thanks John. This looks good to me. I agree with your sentiment re the need for a TF counterpart script. If you can re-factor this folder to include both that would be great. Thanks!

jritsema commented 2 years ago

Here you go @mreferre. Please let me know what you think.

mreferre commented 2 years ago

This is looking good to me. Thanks for doing it!

PS I will modify later the main README file to remove the mention of the CFN script (now that we have both CFN and TF) and I will send the reader to the root of the scripts folder for them to pick which IaC they want to use.

mreferre commented 2 years ago

This is looking good to me. Thanks for doing it!

PS I will modify later the main README file to remove the mention of the CFN script (now that we have both CFN and TF) and I will send the reader to the root of the scripts folder for them to pick which IaC they want to use.

Never mind. Not sure why I did not notice you already did that.