search

aws-samples / eks-blueprints-for-proton

MIT No Attribution
28 stars 30 forks source link

Karpenter not listed in main.tf #32

Closed mreferre closed 2 years ago

mreferre commented 2 years ago

Currently main.tf lists these add-ons: 

  # K8s Add-ons
  enable_aws_for_fluentbit            = var.environment.inputs.aws_for_fluentbit
  enable_aws_load_balancer_controller = var.environment.inputs.aws_load_balancer_controller
  enable_cert_manager                 = var.environment.inputs.cert_manager
  enable_metrics_server               = var.environment.inputs.metrics_server
  enable_vpa                          = var.environment.inputs.vpa

There is no karpenter listed in there and I don't know if it's a refuse or if it's by design. I suspect we are just missing it by mistake but don't want to touch it without being sure.

mreferre commented 2 years ago

Everything seems to be working though (or at least the issues we have do not seem to be related to this entry). I am wondering what this section of main exists for?

kcoleman731 commented 2 years ago

My mistake - I thought we had LBC as well. But I will add back.