feat: Update modules used to latest versions

aws-samples / eks-blueprints-for-proton

MIT No Attribution

28 stars 30 forks source link

feat: Update modules used to latest versions #49

Closed bryantbiggs closed 1 year ago

bryantbiggs commented 1 year ago

Issue #, if available:

N/A: Slack request

Description of changes:

Update modules to use latest versions
Use S3 bucket module with baked in settings for security and versioning of remote state
Add in local tags; this would ideally be replaced by a users own set of tags or tag module but at least we are showing tags and can relate those resources back to this project
Update files to follow Terraform conventions

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

csantanapr commented 1 year ago

Awesome updates @bryantbiggs 💯

adamjkeller commented 1 year ago

Hey @bryantbiggs thank you so much for this PR! For future PR's it would be incredibly helpful to separate whitespace/trailing line corrections into their own commit, as right now it's quite challenging to find where the main changes are.

Will this PR solve the issue we're seeing with the experimental_module errors as well as karpenter version related errors?

bryantbiggs commented 1 year ago

thanks @adamjkeller - yes, its a bit "noisy" with the formatting changes, let me split that out to clean it up a bit.

This does resolve the experimental attribute error with Terraform 1.3+, but I am not aware of any Karpenter issues. If you have some more context I can take a look into that as well

bryantbiggs commented 1 year ago

@adamjkeller I've opeend https://github.com/aws-samples/eks-blueprints-for-proton/pull/50 just for the whitespace formatting changes made by pre-commit