codecov-commenter
commented
1 year ago Codecov Report
Patch coverage: 80.00% and project coverage change: +0.36 :tada:
Comparison is base (
56ccabe) 28.38% compared to head (2f9d8eb) 28.75%.
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #104 +/- ## ========================================== + Coverage 28.38% 28.75% +0.36% ========================================== Files 14 14 Lines 1934 1937 +3 ========================================== + Hits 549 557 +8 + Misses 1385 1380 -5 ``` | [Impacted Files](https://codecov.io/gh/aws-samples/eks-cluster-upgrade/pull/104?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [eksupgrade/src/preflight\_module.py](https://codecov.io/gh/aws-samples/eks-cluster-upgrade/pull/104?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZWtzdXBncmFkZS9zcmMvcHJlZmxpZ2h0X21vZHVsZS5weQ==) | `4.40% <50.00%> (-0.01%)` | :arrow_down: | | [eksupgrade/\_\_init\_\_.py](https://codecov.io/gh/aws-samples/eks-cluster-upgrade/pull/104?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZWtzdXBncmFkZS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | | | [eksupgrade/utils.py](https://codecov.io/gh/aws-samples/eks-cluster-upgrade/pull/104?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZWtzdXBncmFkZS91dGlscy5weQ==) | `100.00% <100.00%> (+20.68%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None):umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Summary
The goal of this PR is to add a deprecation notice to the pre/post-flight checks regarding the deprecation and changes from #103
Resolves: NA
Changes
This PR adds test coverage for the remaining
utils.pymethods, adds the relevant deprecation notice to the pre/post-flight checks, and introduces theecho_deprecationmethod.User experience
When using
0.8.3, a user runningeksupgrade <cluster-name> <version> <region> --preflightoreksupgrade <cluster-name> <version> <region>will receive a notice stating:{Pre|Post}-flight checks will be deprecated in the next minor release in favor of cluster summaries: #103Checklist
If your change doesn't seem to apply, please leave them unchecked.
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.