search

aws-samples / eks-cluster-upgrade

Automated Amazon EKS cluster upgrade
MIT No Attribution
154 stars 35 forks source link

Bug: Running the tool with AWS_PROFILE & role and MFA causes repeated MFA prompts #111

Closed drmaciej closed 1 year ago

drmaciej commented 1 year ago

Expected Behaviour

Consistent with the usual usage of AWS CLI with roles and MFA. One should be prompted for the MFA code only once per duration of the session.

Current Behaviour

I want to utilise my AWS CLI profiles so I run the tool with AWS_PROFILE=drmaciej eksupgrade drmaciej-cluster 1.26 ap-southeast-2 --preflight. My profiles are configured to assume roles and MFA is required.

The tool then seems to ask me for an MFA code for multiple interactions with the AWS API - a new MFA code is ready every 30 seconds, so this slows down the whole experience significantly. For instance:

The pre-flight checks will be deprecated in the next minor release in favor of cluster summaries: #103
Running validation checks against cluster: drmaciej-cluster...
Enter MFA code for arn:aws:iam::123456789012:mfa/drmaciej
Enter MFA code for arn:aws:iam::123456789012:mfa/drmaciej
Verifying User IAM Role...
IAM role for user verified!
Enter MFA code for arn:aws:iam::123456789012:mfa/drmaciej
Fetching cluster details...
Cluster control plane version 1.25
Cluster with version 1.25 can be updated to target version 1.26
Enter MFA code for arn:aws:iam::123456789012:mfa/drmaciej

I cancelled execution after these prompts.

Code snippet

NA

Possible Solution

No response

Steps to Reproduce

Detailed in "Current Behaviour"

Amazon EKS upgrade version

latest

Python runtime version

3.9

Packaging format used

PyPi

Debugging logs

No response

github-actions[bot] commented 1 year ago

This issue has not received any attention in 30 days. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.