aws-samples / eks-cluster-upgrade

Automated Amazon EKS cluster upgrade
MIT No Attribution
154 stars 35 forks source link

refactor: Remove pre-flight checks #112

Closed mbeacom closed 1 year ago

mbeacom commented 1 year ago

Summary

This change totally removes the pre-flight checks in favor of guiding the user to evaluate their clusters with something like eksup or other existing cluster upgrade readiness tools.

Additionally, this PR removes pylint in favor of ruff.

Resolves: #113

Changes

Please provide a summary of what's being changed

User experience

No longer providing the --preflight functionality during upgrade or explicitly.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 22.22% and project coverage change: +10.95 :tada:

Comparison is base (faf227d) 28.75% compared to head (24cb6d2) 39.71%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #112 +/- ## =========================================== + Coverage 28.75% 39.71% +10.95% =========================================== Files 14 13 -1 Lines 1937 1337 -600 =========================================== - Hits 557 531 -26 + Misses 1380 806 -574 ``` | [Impacted Files](https://app.codecov.io/gh/aws-samples/eks-cluster-upgrade/pull/112?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [eksupgrade/src/boto\_aws.py](https://app.codecov.io/gh/aws-samples/eks-cluster-upgrade/pull/112?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZWtzdXBncmFkZS9zcmMvYm90b19hd3MucHk=) | `10.84% <0.00%> (ø)` | | | [eksupgrade/cli.py](https://app.codecov.io/gh/aws-samples/eks-cluster-upgrade/pull/112?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZWtzdXBncmFkZS9jbGkucHk=) | `23.59% <16.66%> (+0.59%)` | :arrow_up: | | [eksupgrade/\_\_init\_\_.py](https://app.codecov.io/gh/aws-samples/eks-cluster-upgrade/pull/112?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZWtzdXBncmFkZS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/aws-samples/eks-cluster-upgrade/pull/112/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

quixoticmonk commented 1 year ago

We should remove the Pre-flights check section in the README or update with the proposal before the version is published.