aws-samples / eks-cluster-upgrade

Automated Amazon EKS cluster upgrade
MIT No Attribution
154 stars 34 forks source link

Maintenance: Re-write self-managed nodegroups logic #117

Closed mbeacom closed 12 months ago

mbeacom commented 1 year ago

Summary

The self-managed nodegroup logic is currently resulting in nodes that are unable to join the target cluster. Reproduction steps will be backfilled here when available.

Per #36:

  1. Update self-managed nodegroups using the graceful termination of the node-termination-handler in coordination with the instance refresh functionality of an autoscaling group. This process should be used if the node-termination-handler is deployed within the cluster, the autoscaling group is monitored by the NTH for lifecycle events, and an instance refresh configuration is present on the launch template used by the autoscaling group
  2. Update self-managed nodegroups using logic similar to that of the EKS managed node group (like this)

Why is this needed?

Current workflow is erroneous.

Which area does this relate to?

No response

Solution

Rewrite the logic for self-managed nodegroups into the new core.

github-actions[bot] commented 1 year ago

This issue has not received any attention in 30 days. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

github-actions[bot] commented 1 year ago

This issue has not received any attention in 30 days. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.