search

aws-samples / eks-kubeflow-workshop

Kubeflow workshop on EKS. Mainly focus on AWS integration examples. Please go check kubeflow website http://kubeflow.org for other examples
Apache License 2.0
96 stars 56 forks source link

Can not compile SageMaker examples #1

Closed Jeffwan closed 4 years ago

Jeffwan commented 4 years ago

Trying our your Kubeflow/SageMaker notebook in your workshop and received a pipeline compile error.

image

Jeffwan commented 4 years ago

This is reported by user and the problem is kubeflow pipeline has some breaking changes on parameters but we always install latest KFP pipeline which is not compatible.

Short term. use lower kfp version

!pip install https://storage.googleapis.com/ml-pipeline/release/0.1.29/kfp.tar.gz --upgrade

Long term, update examples and make sure it leverages latest features of KFP.

PatrickXYS commented 4 years ago

Will check on the SageMaker example and file a PR to make it leverage the latest features of KFP.

PatrickXYS commented 4 years ago

And the master example of SageMaker Kubeflow Pipeline, will try to use master yaml file. After so, will try to use latest version 2.05 of kfp to make it compatible.

PatrickXYS commented 4 years ago

Potential SageMaker example issues with users: 1st and 2nd. But the issue description is not that informative. Will talk with users if necessary.

Jeffwan commented 4 years ago

Let's not put time on this one. I will ask SM team to fix Op issue and we can concentrate on others.

PatrickXYS commented 4 years ago

Since the updated SageMaker example has been merged, let's close this issue.