search

aws-samples / eks-kubeflow-workshop

Kubeflow workshop on EKS. Mainly focus on AWS integration examples. Please go check kubeflow website http://kubeflow.org for other examples
Apache License 2.0
96 stars 56 forks source link

Fix 09_01_Iris_Pipeline_Monitoring component wrong settings and SSL verification issue #41

Closed PatrickXYS closed 4 years ago

PatrickXYS commented 4 years ago

Issue #, if available: In component.yaml file, the output mismatched with fileOutputs

After Python3.6, it doesn't pre-install certifact, thus, when reading from https URL, it will result in the SSL verification issue.

Description of changes: Modified output.name for correct settings.

To bypass the SSL verification issue, I avoid verifying SSL cert.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

PatrickXYS commented 4 years ago

/cc @Jeffwan

PatrickXYS commented 4 years ago

Btw, to clearly set the commit user, we should not only modify the author but committer. Simply modify author will result in User authorized Committer issue.

Jeffwan commented 4 years ago

@PatrickXYS What problem you meet updating author?

PatrickXYS commented 4 years ago

So the problem is when we do git commit, there are committer and author, if we only update author, then you can find something below: image

And to avoid this, we should also update committer, then the commit will be clean as below: image

This happens because, on my own laptop, I utilize my personal email as committer email, after I update it to be my amazon email address, it's fixed.

Jeffwan commented 4 years ago

@PatrickXYS Ok. I don't know your git settings. It's different one by one. My point is making them consistent rather than something unknown.