search

aws-samples / eks-kubeflow-workshop

Kubeflow workshop on EKS. Mainly focus on AWS integration examples. Please go check kubeflow website http://kubeflow.org for other examples
Apache License 2.0
96 stars 56 forks source link

Fix clusterrole previledge issue in 03_02_Distributed_Training_MPI_Ho… #51

Closed PatrickXYS closed 4 years ago

PatrickXYS commented 4 years ago

Issue #50 , if available: Directly editing clusterrole kubeflow-edit won't work because:

Note: If you edit that ClusterRole, your changes will be overwritten on API server restart via auto-reconciliation. To avoid that overwriting, either do not manually edit the role, or disable auto-reconciliation.

Description of changes: We edit kubeflow-kubernetes-edit clusterrole instead.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Jeffwan commented 4 years ago

Is this the only change? Let's try to collect all similar changes and create one PR for them

PatrickXYS commented 4 years ago

I searched in the repo and only found this one.