search

aws-samples / eks-kubeflow-workshop

Kubeflow workshop on EKS. Mainly focus on AWS integration examples. Please go check kubeflow website http://kubeflow.org for other examples
Apache License 2.0
96 stars 56 forks source link

Add examples for Seldon Core Serving #61

Closed PatrickXYS closed 4 years ago

PatrickXYS commented 4 years ago

Issue #59 , if available:

Description of changes: Add one example for Seldon Core Serving.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

PatrickXYS commented 4 years ago

@Jeffwan Can you take a look?

PatrickXYS commented 4 years ago

I confirmed on my side, we need to label namespace with serving.kubeflow.org/inferenceservice=enabled.

And Seldon Serving doc also tells that we need to do so. image

Jeffwan commented 4 years ago

Seldon Serving doc also tells that we need

@PatrickXYS Thanks for confirmation. Seems other frameworks use it as well.

Jeffwan commented 4 years ago

I am still not clear if kubeflow-gateway is a required thing for this example.

Jeffwan commented 4 years ago

It's minor thing and I will merge this.

PatrickXYS commented 4 years ago

I confirmed that kubeflow-gateway in user's namespace is required, I have tried to use kubeflow namespace's kubeflow-gateway but it didn't work. @Jeffwan