search

aws-samples / eks-kubeflow-workshop

Kubeflow workshop on EKS. Mainly focus on AWS integration examples. Please go check kubeflow website http://kubeflow.org for other examples
Apache License 2.0
96 stars 56 forks source link

fixing bug with kfp samgemaker notebook #71

Closed dalbhanj closed 3 years ago

dalbhanj commented 3 years ago

Issue #, if available:https://github.com/aws-samples/eks-kubeflow-workshop/issues/70

Description of changes: I was getting an error while executing kfp run with Sagemaker notebook. Its possible that the latest kfp sdk has breaking changes that affects this run. Pinning to specific kfp version (v0.1.29) fixes the issue

See https://github.com/aws-samples/eks-kubeflow-workshop/issues/70 for more details

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Jeffwan commented 3 years ago

Not sure why there's so many diffs. Checked notebooks and it looks good to me.

Jeffwan commented 3 years ago

Not sure why there's so many diffs. Checked notebooks and it looks good to me.

Jeffwan commented 3 years ago

Thanks @dalbhanj for the fix

swarnaditya commented 3 years ago

import random, string HASH = ''.join([random.choice(string.ascii_lowercase) for n in range(3)] + [random.choice(string.digits) for n in range(3)]) AWS_REGION = 'us-west-2' S3_BUCKET = '{}-kubeflow-pipeline-data'.format(HASH) !aws s3 mb s3://$S3_BUCKET --region $AWS_REGION

make_bucket failed: s3://XXX-data An error occurred (AccessDenied) when calling the CreateBucket operation: Access Denied

facing this error while creating an S3 bucket to store pipeline data

dalbhanj commented 3 years ago

@swarnaditya can you please open new issues on EKS workshop (https://github.com/aws-samples/eks-workshop/issues)? We inherit some permissions from Fairing chapter (where we apply S3 permissions) into this chapter (https://www.eksworkshop.com/advanced/420_kubeflow/fairing/#assign-s3-and-ecr-permissions).

swarnaditya commented 3 years ago

checked both are AmazonS3FullAccess & AmazonEC2ContainerRegistryFullAccess both permission are there.

dalbhanj commented 3 years ago

Can you create an issue on eksworkshop and tag me?