search

aws-samples / eks-kubeflow-workshop

Kubeflow workshop on EKS. Mainly focus on AWS integration examples. Please go check kubeflow website http://kubeflow.org for other examples
Apache License 2.0
97 stars 55 forks source link

Add papermill init test case #79

Closed Jeffwan closed 4 years ago

Jeffwan commented 4 years ago

Issue #, if available:

78

Description of changes: Add a presubmit job to test notebooks using papermill. Only

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Jeffwan commented 4 years ago

/test presubmit-workshop-e2e

Jeffwan commented 4 years ago

/test presubmit-workshop-e2e

Jeffwan commented 4 years ago

/retest

Jeffwan commented 4 years ago

/test presubmit-workshop-e2e

Jeffwan commented 4 years ago

/test presubmit-workshop-e2e

Jeffwan commented 4 years ago

image

Jeffwan commented 4 years ago

/test presubmit-workshop-e2e

Jeffwan commented 4 years ago

/test presubmit-workshop-e2e

Jeffwan commented 4 years ago

/test presubmit-workshop-e2e

Jeffwan commented 4 years ago

/test presubmit-workshop-e2e

Jeffwan commented 4 years ago

/test presubmit-workshop-e2e

Jeffwan commented 4 years ago

/test presubmit-workshop-e2e

Jeffwan commented 4 years ago

/test presubmit-workshop-e2e

Jeffwan commented 4 years ago

/test presubmit-workshop-e2e

Jeffwan commented 4 years ago

/test-presubmit-workshop-e2e

Jeffwan commented 4 years ago

/test presubmit-workshop-e2e

Jeffwan commented 4 years ago

/test presubmit-workshop-e2e

Jeffwan commented 4 years ago 

Executing:   0%|          | 0/5 [00:00<?, ?cell/s]/usr/local/lib/python3.6/dist-packages/IPython/paths.py:67: UserWarning: IPython parent '/home/jovyan' is not a writable location, using a temp directory.
  " using a temp directory.".format(parent))
/usr/local/lib/python3.6/dist-packages/IPython/paths.py:67: UserWarning: IPython parent '/home/jovyan' is not a writable location, using a temp directory.
  " using a temp directory.".format(parent))

Executing:  20%|██        | 1/5 [00:00<00:03,  1.32cell/s]
Executing:  60%|██████    | 3/5 [02:22<00:43, 21.74s/cell]
Executing:  80%|████████  | 4/5 [02:23<00:15, 15.47s/cell]
Executing: 100%|██████████| 5/5 [02:23<00:00, 11.07s/cell]
Executing: 100%|██████████| 5/5 [02:25<00:00, 29.04s/cell]

test runs pretty well

Jeffwan commented 4 years ago

/approve

PatrickXYS commented 4 years ago

Let me know if you need lgtm to merge

Jeffwan commented 4 years ago

@PatrickXYS Let's merge it

Jeffwan commented 4 years ago

/approve

aws-kf-ci-bot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jeffwan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/aws-samples/eks-kubeflow-workshop/blob/master/OWNERS)~~ [Jeffwan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
PatrickXYS commented 4 years ago

/lgtm