search

aws-samples / iam-identity-center-team

Open-source temporary elevated access solution for AWS IAM Identity Center.
https://aws-samples.github.io/iam-identity-center-team/
MIT No Attribution
250 stars 59 forks source link

Improve deployment logging #209

Closed fatbasstard closed 1 month ago

fatbasstard commented 3 months ago

Description of changes:

This PR adds an additional log of logging in case the App cannot be found. Of course I deployed the Amplify app with a different name (which might be a nice feature to add in the future) which broke the deployment.

Only error in Cloudwatch was: "check cloudwatch for error". Looking at the Lambda it made sense. This PR adds "App not found" to the Data of the response so the reason of the failure is there

Since the Lambda is inline, here's the snippet of the code for readability:

else:
    responseData['Data'] = "Amplify App TEAM-IDC-APP not found"
    cfnresponse.send(event, context, cfnresponse.FAILED, responseData)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

github-actions[bot] commented 1 month ago

Marking this pull request as stale due to inactivity. This helps our maintainers find and focus on the active pull requests.

fatbasstard commented 1 month ago

Can this be re-opened?