search

aws-samples / iam-identity-center-team

Open-source temporary elevated access solution for AWS IAM Identity Center.
https://aws-samples.github.io/iam-identity-center-team/
MIT No Attribution
295 stars 67 forks source link

GrantStateMachine does not retry on SsoAdmin.ThrottlingException #256

Closed lukasgabi closed 1 month ago

lukasgabi commented 3 months ago

Describe the bug Grant Permission step fails on Throttling Excepion instead of retrying with backoff strategy.

To Reproduce Steps to reproduce the behavior: Hard to reproduce because it's a transient issue, however other step function steps have retries, looks to me like here it was forgotten.

Expected behavior Transient errors should be handled by retry logic instead of throwing an error.

Additional context

https://github.com/aws-samples/iam-identity-center-team/blob/bb7a119edf9f696851cce5a8fd644c8e26e3df37/amplify/backend/custom/stepfunctions/stepfunctions-cloudformation-template.json#L66-L88

github-actions[bot] commented 1 month ago

Marking this issue as stale due to inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 7 days it will automatically be closed.