aws-samples / iam-identity-center-team

Open-source temporary elevated access solution for AWS IAM Identity Center.
https://aws-samples.github.io/iam-identity-center-team/
MIT No Attribution
295 stars 67 forks source link

No notification in Slack when request is by member of TEAM admin group #276

Closed iankyslytsya closed 3 weeks ago

iankyslytsya commented 3 months ago

Describe the bug No notifcation in Slack when request was created by a user who is in the TEAM admin group.

To Reproduce Member of TEAM admin group creates a request to get access to an account

image

image

Expected behavior A notification would be sent to all members of the TEAM admin group even if they are the ones submitting a request.

Additional context v 1.1.2 Slack notifications are configured. Slack is also added to a private Slack channel to test and see whether notifications can be visible by non-Approvers. SES and SNS is not configured. Cannot test at this time with another user to confirm whether notifications are sent at all.

iankyslytsya commented 3 months ago

Tested with other user: notifications are sent to Slack when the requester is not a member of the Admin Group and is also not an Approver.

github-actions[bot] commented 1 month ago

Marking this issue as stale due to inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 7 days it will automatically be closed.