Closed richlv closed 1 year ago
Sure, added (hopefully this was done correctly). I also changed several occurrences of "per regions" to "per region".
I'd might further nitpick on comment formatting and consistency - for example, adding a space after # and making them all start with upper or lower case, currently it's inconsistent (like a comment "No argument given with -da option" being followed by "use the argument given with -da" a few lines later) - but that seems out of scope for typo fixes.
Hello @richlv thank you so much for taking the time to correct those typos. I am working on updating the README to add the support for Lambda code scanning.
I would take into considerations your typos corrections.
Please don't take offense if I don't access your pull request, I have already started making the changes on my local version.
Once again, thank you truly for your time.
Regards,
@richlv can you also add to your PR another spelling/grammar change? On line 281 here: https://github.com/aws-samples/inspector2-enablement-with-cli/blob/main/inspector2_enablement_with_awscli.sh#L281
# Because there is a loop on each account, this code is not subject to throttling API issue: only ONE account is process at the tie
change
to
Also, line 425: https://github.com/aws-samples/inspector2-enablement-with-cli/blob/main/inspector2_enablement_with_awscli.sh#L425 the comment
local_del_admin="$1" #use the argupment given with -da
change:`to