search

aws-samples / lambda-ecs-worker-pattern

This example code illustrates how to extend AWS Lambda functionality using Amazon SQS and the Amazon EC2 Container Service (ECS).
Apache License 2.0
290 stars 45 forks source link

Which SSH_KEY_NAME? #13

Closed Niemetz closed 4 years ago

Niemetz commented 4 years ago

Hi Constantin In your config.py you have an env var SSH_KEY_NAME. Is this the SSH private key for Docker Registry or it is for AWS SSH? Also in the same file you have two env vars AWS_REGION and AWS_PROFILE. What is the reason I need to spicy both while the AWS_PROFILE already contains the REGION? Thanks John Nguyen

glez-aws commented 4 years ago

Hi John,

the SSH_KEY_NAME is your EC2 SSH Key for logging into your ECS Cluster so the script can build the Docker image.

Again, this is 5 year old example, and today, I would advise to use a more modern approach: Today, I would use Amazon ECR to store the Docker images because it is easier to integrate. Similary, I would propose to use AWS Code Build in order to build Docker images, instead of logging into an EC2 ECS Cluster over SSH. You can find out more here:

https://aws.amazon.com/ecr/ https://docs.aws.amazon.com/codebuild/latest/userguide/sample-docker.html

Hope this helps, Constantin

Niemetz commented 4 years ago

ic... thanks again... please ignore my last note thenAnd thanks for the tips of ECR and CodeBuild.  I'll take a look at them.J.N On Wednesday, February 12, 2020, 11:46:30 AM EST, Constantin Gonzalez notifications@github.com wrote:

Hi John,

the SSH_KEY_NAME is your EC2 SSH Key for logging into your ECS Cluster so the script can build the Docker image.

Again, this is 5 year old example, and today, I would advise to use a more modern approach: Today, I would use Amazon ECR to store the Docker images because it is easier to integrate. Similary, I would propose to use AWS Code Build in order to build Docker images, instead of logging into an EC2 ECS Cluster over SSH. You can find out more here:

https://aws.amazon.com/ecr/ https://docs.aws.amazon.com/codebuild/latest/userguide/sample-docker.html

Hope this helps, Constantin

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

glez-aws commented 4 years ago

Closing as this seems resolved now. Feel free to reopen otherwise.