Modify Dokerfile to remove unsuported `lerna link` command (legacy)

aws-samples / lza-validator

Build a tool that can validate configurations of Landing Zone Accelerator on AWS.

MIT No Attribution

10 stars 7 forks source link

Modify Dokerfile to remove unsuported `lerna link` command (legacy) #2

Closed at3rva closed 1 year ago

at3rva commented 1 year ago

Issue #, if available: Broken container build, errors:

https://lerna.js.org/docs/legacy-package-management
husky - git command not found, skipping install

Description of changes: Modify Dokerfile to remove unsuported lerna link command (legacy) and to install git

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

jc1518 commented 1 year ago

Thanks for reporting the issue, it was due to a breaking change that was introduced in Lerna v7 (staring from LZA 1.5.x, it uses Lerna v7). We will need to work out a way to support both pre 1.5.X and current LZA versions.

jc1518 commented 1 year ago

This has been solved in PR https://github.com/aws-samples/lza-validator/pull/3