aws-samples / mlops-e2e

MLOps End-to-End Example using Amazon SageMaker Pipeline, AWS CodePipeline and AWS CDK
MIT No Attribution
118 stars 77 forks source link

Modifying Lambda Runtime and AWS SDK and Boto3 versions. Modifying Deployment scripts and build spec files. #74

Closed imsalmanmalik closed 1 month ago

imsalmanmalik commented 2 months ago

Issue #, if available:

Description of changes: Adjusting the Lambda run time issues from Nodejs.14x to Nodejs.18x and modifying structure of build spec files and deploy scripts for consistency. Incrementing boto3 and aws sdk versions. Adding some additional parameters and packages required dependancy.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

jessieweiyi commented 2 months ago

Hi @imsalmanmalik Thanks for your contribution. I will review your PR later in the week.

jessieweiyi commented 2 months ago

Hi @imsalmanmalik could you please review the file configuration/projectConfig.json?

I saw you removed yarn.lock files and change yarn install --frozen-lockfile to yarn install. But we will need that to ensure the version consistency. I am happy to take your contribution once you fix the config file and continue on working on that.

Thanks.

jessieweiyi commented 1 month ago

Hi @imsalmanmalik Thanks for your contributions. We have solved this issue in PR #79 with both lambda runtime upgrade and aws-sdk upgrade.