aws-samples / mwaa-disaster-recovery

Disaster recovery solution for Amazon Managed Workflows for Apache Airflow (MWAA)
https://github.com/aws-samples/mwaa-disaster-recovery
MIT No Attribution
5 stars 5 forks source link

MWAA 2.4.3 support #23

Closed mathiasflorin closed 3 months ago

mathiasflorin commented 3 months ago

What type of PR is this? (check all applicable)

Description

Add MWAA 2.4.3 support Add XCOM table Add development notes

Related Tickets & Documents

Linting

Have you done linting by issuing ./build.sh lint command?

Testing

Have you run testing by issuing ./build.sh unit command?

Documentation

Have you updated the README appropriate for this PR?

Changelog

Have you updated the CHANGELOG with the changes you are making in this PR? Please use Added, Removed, and/or Changed subsections under the Unreleased section.

Terms of Contribution

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

crupakheti commented 3 months ago

Hello @mathiasflorin ! Appreciate your contribution to the repo! We will get the PR review started soon! Thank you!

crupakheti commented 3 months ago

@mathiasflorin Let's start by fixing the build failures please. Could you please lint and push? Thank you!

mathiasflorin commented 3 months ago

Yes, I ran the lint before but I forgot to run it again after adding a minor commit with small fixes. Thanks for your review. I will rerun the unit test and lint in a few hours and push the required changes to fulfil the black format.

github-actions[bot] commented 3 months ago

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  assets/dags/mwaa_dr/framework/factory
  base_dr_factory.py
  assets/dags/mwaa_dr/framework/model
  base_table.py
  assets/dags/mwaa_dr/v_2_4
  dr_factory.py
  assets/dags/mwaa_dr/v_2_5
  dr_factory.py
Project Total  

This report was generated by python-coverage-comment-action

mathiasflorin commented 3 months ago

@crupakheti Could you please help me to resolve this pipeline error To fix this, change your publishing workflow to use an event that forks of your repository cannot trigger (such as tag or release creation, or a manually triggered workflow dispatch).

crupakheti commented 3 months ago

Hey @mathiasflorin, please don't worry about that error. I will need to change the publishing workflow to fix it. I have allocated time to review your PR tomorrow. Thank you!

crupakheti commented 3 months ago

@mathiasflorin Looks like the testing was mostly done on the local container. I will need to push some changes based on the CDK deployment error I got. Will make a push soon. Thanks!

mathiasflorin commented 3 months ago

@mathiasflorin Looks like the testing was mostly done on the local container. I will need to push some changes based on the CDK deployment error I got. Will make a push soon. Thanks!

Thank you @crupakheti for your solution and your review. I deployed the stack only once, but I ended up using a manually created 2.4.3 MWAA environment for further testing of the backup and restore process.

mathiasflorin commented 3 months ago

Based on the ERD diagram, it seems that dag_run and trigger should be exported before task_instance, as task_instance has foreign keys referencing these tables. Although I didn’t encounter an import error, it might be necessary to implement downstream relationships for these tables and any other exported tables with foreign keys in the future.

crupakheti commented 3 months ago

@mathiasflorin Thank you for your contribution! This PR has been merged to main!