aws-samples / mwaa-disaster-recovery

Disaster recovery solution for Amazon Managed Workflows for Apache Airflow (MWAA)
https://github.com/aws-samples/mwaa-disaster-recovery
MIT No Attribution
5 stars 5 forks source link

Add 2.10.1 support #33

Open pyrr opened 1 week ago

pyrr commented 1 week ago

What type of PR is this? (check all applicable)

Description

Adds support for the MWAA/Airflow 2.10.1 release.

Related Tickets & Documents

Linting

Have you done linting by issuing ./build.sh lint command?

Testing

Have you run testing by issuing ./build.sh unit command?

Documentation

Have you updated the README appropriate for this PR?

Changelog

Have you updated the CHANGELOG with the changes you are making in this PR? Please use Added, Removed, and/or Changed subsections under the Unreleased section.

Terms of Contribution

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

crupakheti commented 1 week ago

Thank you, @pyrr , for your code contribution. I will get started with the PR review at the tail end of this week. In the meantime, please ensure that all of the tests are passing. And don't worry about the CI release error for TestPyPI. Thank you!

pyrr commented 1 week ago

Thank you, @pyrr , for your code contribution. I will get started with the PR review at the tail end of this week. In the meantime, please ensure that all of the tests are passing. And don't worry about the CI release error for TestPyPI. Thank you!

Thanks! I did run into those errors on my side but I thought they were related to my environment, will attempt to fix myself.

Just FYI I was able to run build.sh setup 2_10 and successfully run some manual integration tests.

pyrr commented 1 week ago

@crupakheti

Fixed issue and unit tests pass on my side. Workflows should be good to re-run.

pyrr commented 6 days ago

Just tested my fork in our staging environment using MWAA 2.10.1 and it works as expected for the backup, cleanup, and restore dags.

github-actions[bot] commented 5 days ago

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  .
  config.py
  assets/dags/mwaa_dr/framework/factory
  base_dr_factory.py
  default_dag_factory.py
  assets/dags/mwaa_dr/framework/model
  active_dag_table.py
  base_table.py
  connection_table.py
  variable_table.py
  assets/dags/mwaa_dr/v_2_10
  dr_factory.py
  lib/dr_constructs
  airflow_cli.py
  lib/functions
  airflow_cli_client.py
  airflow_cli_function.py
  lib/stacks
  mwaa_base_stack.py
  mwaa_primary_stack.py
  mwaa_secondary_stack.py
Project Total  

This report was generated by python-coverage-comment-action