Add support for Direct VPC Routing

aws-samples / otl-service-launcher

MIT No Attribution

3 stars 3 forks source link

Add support for Direct VPC Routing #21

Open cmlccie opened 3 years ago

cmlccie commented 3 years ago

Attempting to deploy the otl-service-launcher configurations on an Outpost configured for Direct VPC Routing (private preview) results in the following error:

❯ terraform apply
╷
│ Error: no matching COIP Pool found
│
│   with data.aws_ec2_coip_pool.outpost_coip_pool,
│   on outposts.tf line 20, in data "aws_ec2_coip_pool" "outpost_coip_pool":
│   20: data "aws_ec2_coip_pool" "outpost_coip_pool" {
│
╵

adam-imeson commented 3 years ago

I'm inclined to ignore this problem until DVR launches soon(TM), at which point it'll be a lot easier to integrate with it. That being said... maybe it would make sense to rip out the COIP pool references altogether? I'll have to dig through the code to find the dependencies on that data object.

cmlccie commented 3 years ago

I did a quick hack and removed all the coip references, which worked fine for my use case. However, a more modular approach will be needed here in these modules as customers will need to be able to support both CoIP and DVR LGW deployments.