Closed mtfranchetto closed 1 year ago
Replace previous AWS UI design system with Cloudscape. While the two libraries, in theory, can be swapped freely, doing this migration required a rework of some components, as they weren't used in a Cloudscape-compatible way.
Fixes https://github.com/aws-samples/pcluster-manager/issues/261
AppLayout
Manual tour of every section of the portal, making sure the UI is consistent across every page, on both Chrome and Firefox
i18n
npm run build
In order to increase the likelihood of your contribution being accepted, please make sure you have read both the Contributing Guidelines and the Project Guidelines
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Description
Replace previous AWS UI design system with Cloudscape. While the two libraries, in theory, can be swapped freely, doing this migration required a rework of some components, as they weren't used in a Cloudscape-compatible way.
Fixes https://github.com/aws-samples/pcluster-manager/issues/261
Main changes
AppLayout
component - previously the global AppLayout in combination with a locally overridden layout resulted in a double AppLayout for some pages, leading to unexpected paddings and spacings (https://github.com/aws-samples/pcluster-manager/commit/8584b7e493e05826e18e90cb64dca5306a25d693 and https://github.com/aws-samples/pcluster-manager/commit/8584b7e493e05826e18e90cb64dca5306a25d693)How Has This Been Tested?
Manual tour of every section of the portal, making sure the UI is consistent across every page, on both Chrome and Firefox
UI
PR Quality Checklist
i18n
solution instead (see here)npm run build
builds without any errorIn order to increase the likelihood of your contribution being accepted, please make sure you have read both the Contributing Guidelines and the Project Guidelines
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.