Closed sean-smith closed 1 year ago
Hi @sean-smith, while I understand the problem you're trying to solve with this this pull request, I don't think the solution implemented here fits very well in PCM and its future evolution because:
TopBar
it becomes a button, which shouldn't be in this case as it's a mere text info, with wrong accessibility hintsFor these reasons I'm going to close this pull request. Feel free to engage with both the product and design team to discuss a proper solution for this problem. Thank you
Description
Display ParallelCluster API version in the top bar. This helps customers identify the version that PCM is deployed with and allows them to easily see which clusters they can update.
Changes
Changelog entry
How Has This Been Tested?
Tested by deploying manually
References
PR Quality Checklist
i18n
solution instead (see here)npm run build
builds without any errorIn order to increase the likelihood of your contribution being accepted, please make sure you have read both the Contributing Guidelines and the Project Guidelines
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.