Closed tmscarla closed 1 year ago
Following https://github.com/aws-samples/pcluster-manager/pull/419 and https://github.com/aws-samples/pcluster-manager/pull/420, this PR is the first step towards replacing all instances of HelpTooltip with useHelpPanel() hook calls in order to be compliant with the CloudScape help system.
HelpTooltip
useHelpPanel()
This PR fixes also the link in the footer of TitleDescriptionHelpPanel which was not opening a new tab when clicked.
TitleDescriptionHelpPanel
info
i18n
npm run build
In order to increase the likelihood of your contribution being accepted, please make sure you have read both the Contributing Guidelines and the Project Guidelines
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Description
Following https://github.com/aws-samples/pcluster-manager/pull/419 and https://github.com/aws-samples/pcluster-manager/pull/420, this PR is the first step towards replacing all instances of
HelpTooltip
withuseHelpPanel()
hook calls in order to be compliant with the CloudScape help system.This PR fixes also the link in the footer of
TitleDescriptionHelpPanel
which was not opening a new tab when clicked.How Has This Been Tested?
info
link and verified that help panel is opened and filled as expectedReferences
PR Quality Checklist
i18n
solution instead (see here)npm run build
builds without any errorIn order to increase the likelihood of your contribution being accepted, please make sure you have read both the Contributing Guidelines and the Project Guidelines
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.