Closed mendaomn closed 1 year ago
This PR removes the notify() call from the error case of the UpdateCluster command (same as it had been already done with the CreateCluster)
notify()
UpdateCluster
CreateCluster
The error is handled via the errorHandler which takes care of setting the errors in the store
errorHandler
This also avoid displaying an error Flash message, in case of successful dry run (see screenshot below)
i18n
npm run build
In order to increase the likelihood of your contribution being accepted, please make sure you have read both the Contributing Guidelines and the Project Guidelines
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Description
This PR removes the
notify()
call from the error case of theUpdateCluster
command (same as it had been already done with theCreateCluster
)The error is handled via the
errorHandler
which takes care of setting the errors in the storeThis also avoid displaying an error Flash message, in case of successful dry run (see screenshot below)
How Has This Been Tested?
PR Quality Checklist
i18n
solution instead (see here)npm run build
builds without any errorIn order to increase the likelihood of your contribution being accepted, please make sure you have read both the Contributing Guidelines and the Project Guidelines
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.