aws-samples / pcluster-manager

Manage AWS ParallelCluster through an easy to use web interface
https://pcluster.cloud
Apache License 2.0
65 stars 27 forks source link

Remove error notification from the UpdateCluster command #437

Closed mendaomn closed 1 year ago

mendaomn commented 1 year ago

Description

This PR removes the notify() call from the error case of the UpdateCluster command (same as it had been already done with the CreateCluster)

The error is handled via the errorHandler which takes care of setting the errors in the store

This also avoid displaying an error Flash message, in case of successful dry run (see screenshot below)

image

How Has This Been Tested?

PR Quality Checklist

In order to increase the likelihood of your contribution being accepted, please make sure you have read both the Contributing Guidelines and the Project Guidelines

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.