This PR fixes an issue causing the Storage tab to crash the app when the filesystem is not ready yet.
The root cause was the construction of link to the filesystem, which depends on the head node information to be available. More precisely, the headNode.instanceId property access cases an error due to the headNode being undefined.
The fix is as follows:
until the headnode is not available, the filesystem is listed without the link to the console
when the headnode is available, the link is correctly shown
See screenshots below:
Link not available due to missing information:
Link available:
Changes
add buildFilesystemLink function to create the link
avoid displaying a <Link/>, when the href is missing
Changelog entry
Fix storage tab crashing when headnode is not available yet
How Has This Been Tested?
manually
unit tests
PR Quality Checklist
[x] I added tests to new or existing code
[ ] I removed hardcoded strings and used our i18n solution instead (see here)
[ ] I made sure no sensitive info gets logged at any time in the codebase (see here) (e.g. no user info or details, no stacktraces, etc.)
[ ] I checked that infrastructure/update_infrastructure.sh runs without any error
[x] I checked that npm run build builds without any error
[x] I checked that clusters are listed correctly
[x] I checked that a new cluster can be created (config is produced and dry run passes)
[ ] I checked that login and logout work as expected
Description
This PR fixes an issue causing the Storage tab to crash the app when the filesystem is not ready yet.
The root cause was the construction of link to the filesystem, which depends on the head node information to be available. More precisely, the
headNode.instanceIdproperty access cases an error due to theheadNodebeing undefined.The fix is as follows:
See screenshots below:
Link not available due to missing information:
Link available:
Changes
buildFilesystemLinkfunction to create the link<Link/>, when the href is missingChangelog entry
Fix storage tab crashing when headnode is not available yet
How Has This Been Tested?
PR Quality Checklist
i18nsolution instead (see here)npm run buildbuilds without any errorIn order to increase the likelihood of your contribution being accepted, please make sure you have read both the Contributing Guidelines and the Project Guidelines
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.