aws-samples / pcluster-manager

Manage AWS ParallelCluster through an easy to use web interface
https://pcluster.cloud
Apache License 2.0
65 stars 27 forks source link

Improved validation constraints for API signatures #485

Closed BarcoMasile closed 1 year ago

BarcoMasile commented 1 year ago

Description

Added size constraints to API signatures validation

Changelog entry

How Has This Been Tested?

References

PR Quality Checklist

In order to increase the likelihood of your contribution being accepted, please make sure you have read both the Contributing Guidelines and the Project Guidelines

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

BarcoMasile commented 1 year ago

question: shouldn't the test reflect the newly introduced constraints somehow?

I'd say no since validators are part of the third library so since we have tests proving our mechanism (that relies on Marshmallow) works, then it's ok to assume they did their job also

lazyoft commented 1 year ago

question: shouldn't the test reflect the newly introduced constraints somehow?

I'd say no since validators are part of the third library so since we have tests proving our mechanism (that relies on Marshmallow) works, then it's ok to assume they did their job also

You are right. I'm ok with these changes.