aws-samples / private-llm-qa-bot

257 stars 62 forks source link

update the Chatglm3 handle to fit the parameter input change in query_rewrite #305

Open mengchen-tam opened 3 months ago

mengchen-tam commented 3 months ago

Issue Chatglm3 endpoint deployment has two errors in 1.3.6:

  1. max_length not defined error
  2. temperature =0.0 error

Description of changes:

  1. add default max_token parameter value in handle
  2. change temperature = 0.01 if the input value is 0.0

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

mengchen-tam commented 3 months ago

hi @ybalbert001 , I dont have write access to this repo so cannot merge this PR. please help merge if it is fine. thanks!