search

aws-samples / rancher-on-aws-workshop

Learn how to easily deploy and manage Kubernetes with Rancher on AWS Cloud
https://catalog.workshops.aws/rancher
MIT License
12 stars 4 forks source link

clean up prose, clarify some content #52

Closed evdevr closed 10 months ago

evdevr commented 11 months ago

Issue #, if available: https://github.com/aws-samples/rancher-on-aws-workshop/issues/51

Description of changes: Clean up prose & clarify content throughout.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

evdevr commented 11 months ago

Build ID: 1267e9ec-c9af-4e4c-8747-f480b85c7a3e Successful build. 1 expected infrastructure error (single region workshop), can safely ignore.

Preview link (Amazon login required): https://studio.us-east-1.prod.workshops.aws/preview/be7b2281-57e8-44d0-a40e-1b7ea0d88f2a/builds/1267e9ec-c9af-4e4c-8747-f480b85c7a3e/en-US

zackbradys commented 10 months ago

Are we sure the "title: " fields should be single quoted? Not sure if VS Code auto-updated or if it was purposeful for the workshop environment? There's 15 or 16 occurrences.

evdevr commented 10 months ago

Are we sure the "title: " fields should be single quoted? Not sure if VS Code auto-updated or if it was purposeful for the workshop environment? There's 15 or 16 occurrences.

VS Code auto-updated that. It looks like it rendered fine in the preview build, so I assume Workshop Studio can use either.