search

aws-samples / rancher-on-aws-workshop

Learn how to easily deploy and manage Kubernetes with Rancher on AWS Cloud
https://catalog.workshops.aws/rancher
MIT License
12 stars 4 forks source link

Changed the DependsOn value for the RancherELB to PublicGatewayAttach… #75

Closed razavi32 closed 1 month ago

razavi32 commented 3 months ago

…ment

Issue: Creating a stack was failing due to timing of the IGW to VPC attachment and RancherELB being created.
Description of changes: Replaced DependsOn value from PublicInternetGateway to PublicGatewayAttachment to ensure the RancherELB wouldnt fail to create due to a VPC without an IGW.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

zackbradys commented 2 months ago

hey @razavi32, thank you for taking the time to contribute and the improve this workshop! could you please update the other cloud formation template, with the same update? file is static/rke2-eks-cluster-workshop.yaml

razavi32 commented 1 month ago

@zackbradys no worries, done.