aws-samples / retail-demo-store

AWS Retail Demo Store is a sample retail web application and workshop platform demonstrating how AWS infrastructure and services can be used to build compelling customer experiences for eCommerce, retail, and digital marketing use-cases
MIT No Attribution
727 stars 516 forks source link

images deploy / private buckets #552

Closed BastLeblanc closed 9 months ago

BastLeblanc commented 9 months ago

Issue #, if available:

Description of changes:

Description of testing performed to validate your changes (required if pull request includes CloudFormation or source code changes):

Known issues:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

james-jory commented 9 months ago

Do we still need a script that updates the private bucket behind the CloudFront distribution? Minimally, this script would update and copy the images zip and copy the generated CSVs.

BastLeblanc commented 9 months ago

Do we still need a script that updates the private bucket behind the CloudFront distribution? Minimally, this script would update and copy the images zip and copy the generated CSVs.

I propose to keep the existing buildspec.yml and stage to the private bucket behind the code.retaildemostore.retail.aws.dev cloudfront distribution. So we have all the code available on this cloudfront distribution, lambda function, csv, etc. Images are static and only updated if we modify them (not included in the github repo)