search

aws-samples / saas-reference-architecture-ecs

This repo provides an end to end SaaS reference architecture implementation using Amazon Elastic Container Service (ECS)
MIT No Attribution
58 stars 19 forks source link

Fix staticSite initialization and improve import statements #24

Open KennyDizi opened 1 month ago

KennyDizi commented 1 month ago

PR Type

bug_fix, enhancement

Description

Changes walkthrough

Relevant files
Bug fix
control-plane-stack.ts
Fix staticSite initialization and improve imports               
server/lib/bootstrap-template/control-plane-stack.ts
  • Changed import statement for path to use * as path.
  • Fixed trailing spaces in the code.
  • Initialized staticSite as a class property.
    		• +4/-4     
    Enhancement
    core-appplane-stack.ts
    Improve path import and JSON formatting                                   
    server/lib/bootstrap-template/core-appplane-stack.ts
  • Changed import statement for path to use * as path.
  • Improved formatting of JSON in PolicyDocument.
    		• +14/-14 

    By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

    KennyDizi commented 1 month ago

    🌟 🎇 I've updated the PR description to match the latest commit (https://github.com/aws-samples/saas-reference-architecture-ecs/commit/69b5a289c9982ca91672c14e5bd38789954227e8).

    KennyDizi commented 1 month ago

    @Hoseong-Seo Would you take a look at this PR?

    Hoseong-Seo commented 1 month ago

    Hi!!! Thank you so~ much for your interest. Could you describe a little more about a bug?