aws-samples / saas-reference-architecture-ecs

This repo provides an end to end SaaS reference architecture implementation using Amazon Elastic Container Service (ECS)
MIT No Attribution
58 stars 19 forks source link

modify the way to retrieve IDs of AZs in the region. #6

Closed beansandroasters closed 4 months ago

beansandroasters commented 4 months ago

Issue #, if available: In shared-infra-stack.ts, the IDs of AZs are fixed as a, b and c. In the region like Tokyo (ap-northeast-1), AZ-b is not available anymore, which cases deploy error.

Description of changes: I made a change with shared-infra-stack.ts.

  1. Import Fn module.
  2. Add the code to retrieve AZs available in a region.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Hoseong-Seo commented 4 months ago

Thank you for your contribution. It's a really great point. But to follow your point, I think it is one more file to be changed to prevent erroneous. Did you check all three tiers in your region(Japan)?