search

aws-samples / sagemaker-run-notebook

Tools to run Jupyter notebooks as jobs in Amazon SageMaker - ad hoc, on a schedule, or in response to events
Apache License 2.0
142 stars 69 forks source link

Installation fails for 3.10 with "ValueError: Python version 3.10 unsupported" #35

Closed jdreamerz closed 2 years ago

jdreamerz commented 2 years ago

Your code for ensure_python is doing an eval(part + spec), which for spec =">=3.5" and a python version 3.10 ends up being eval("3.10>=3.5"), to check for whether it's compatible. But that's not how software versioning works, 3.10 != 3.1 which is what the eval is treating is as when running.

tomfaulhaber commented 2 years ago

Thanks for catching this, @jdreamerz!