search

aws-samples / sagemaker-run-notebook

Tools to run Jupyter notebooks as jobs in Amazon SageMaker - ad hoc, on a schedule, or in response to events
Apache License 2.0
142 stars 69 forks source link

JupyterLab extension not getting installed correctly #66

Closed vinayvaddiparthi closed 1 year ago

vinayvaddiparthi commented 2 years ago

The JupyterLab extension isn't getting installed correctly using the provided lifecycle configuration hooks in both Notebook instances and Studio.

Part of the reason seems to be due to the fact that it is referencing an old repo ("https://github.com/awslabs/sagemaker_run_notebook.git) here which doesn't exist anymore.

Should it be replaced with the current repo? Is any one using this extension?

morales-michelle commented 2 years ago

I am also unable to get this to work. I tried the script .

@vinayvaddiparthi did you have any luck with this? Or anyone else.

mayan-aakash commented 2 years ago

Facing the same issue. The extension doesn't show up anymore. I've tried changing my default Jupyter lab versions and running the lifecycle configuration script on app start. Any luck with this problem?

chetapgit commented 2 years ago

same here, not able to get it working

vinayvaddiparthi commented 2 years ago

I got this working by updating the Git URLs in the code to this repo. I have created a PR with the required changes.

I also have a few releases in my personal fork with these changes which are working for me. Feel free to use that or build your own release and use that until the issue in this repo is fixed.

Happy to help with any questions that anyone might have.

tomfaulhaber commented 1 year ago

I don't think that those URL changes would fix these problems. While you are correct that those are the wrong URLs, I believe they are only used to document the package, not as part of the installation.

Almenon commented 1 year ago

The extension shows up for me, although I looked at the code and I don't know how it does it. The start.sh script defines a EXTENSION_NAME but never references it and never runs the install command!

It seems to be like it should be doing something like this: https://github.com/aws-samples/amazon-sagemaker-notebook-instance-lifecycle-config-samples/blob/master/scripts/install-lab-extension/on-start.sh#L15 🤔

vinayvaddiparthi commented 1 year ago

Good to know that it is working fine for you!

My hunch is that these commands build and install the extension and fixing the repo URL fixed it. I'll close this issue since it is no longer an issue now.